Add card feature to msteamsv2_config #4243
Conversation
Signed-off-by: jverger <[email protected]>
Signed-off-by: jverger <[email protected]>
|
All checks have passed 🎉 , waiting for someone to merge this PR ⌚ |
|
I would really like to avoid pushing users towards templating JSON blobs. It has a lot of problems that I've explained in a couple other PRs such as #3799 (comment). I think supporting cards would be excellent, because visually its a massive improvement, but just not with templated JSON. |
|
Nevermind, I would have try. |
|
What if you made cards the default instead of a separate field, using the template you have already written? Visually it looks so much better in my opinion! |
|
Hello @grobinson-grafana ! I'm trying to add a card template in the I think that i've correctly defined the card template but it does not seem to detect it... Some help is needed |
The goal of this PR is to add an option
cardto themsteamsv2_configconfiguration.If this
cardoption is not used, the default behaviour is keept usingtitleandtextvalues.Here is an example screenshot of the default result in msteams channel:
When using
cardoption, the user is able to customize the msteams card rendering output by using a custom template file and configuringcardoption to use this template.Here is an example screenshot of the output result in msteams channel when using
cardoption:To be honest, it's the first time i'm developing in go and create a PR.
Hope it will be not so bad :)